Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scide: DocumentSelectPopUp - convert to Popup to fix lost KeyRelease event #1352

Merged

Conversation

timblechmann
Copy link
Contributor

ctrl-tab executes this dialog, but the KeyRelease event may be lost if
the window flag is not marked as Qt::Popup

Signed-off-by: Tim Blechmann tim@klingt.org

…event

ctrl-tab executes this dialog, but the KeyRelease event may be lost if
the window flag is not marked as Qt::Popup

Signed-off-by: Tim Blechmann <tim@klingt.org>
telephon added a commit that referenced this pull request Mar 21, 2015
scide: DocumentSelectPopUp - convert to Popup to fix lost KeyRelease event
@telephon telephon merged commit 123909d into supercollider:master Mar 21, 2015
@bagong
Copy link
Contributor

bagong commented Mar 21, 2015

I think this merge was premature :) This breaks the file-selector functionality for me. The popup opens, but alt-tab does nothing and you can't get away from it except by selecting a file and double-clicking it...

@timblechmann
Copy link
Contributor Author

the symptoms you show are the ones that i've actually fixed with this commit. maybe it does not work on your platform, but "me" does not give any details on that.

@bagong
Copy link
Contributor

bagong commented Mar 21, 2015

@telephon, old Mac-brother using alt-tab, does it work for you?

@bagong
Copy link
Contributor

bagong commented Mar 21, 2015

Btw @timblechmann, I just tried it on Ubuntu 14.04, Qt5.2.1, and it works as expected with Dialog... I wonder what you are after...

@telephon
Copy link
Member

@telephon, old Mac-brother using alt-tab, does it work for you?

alt-tab works here (OS X 10.10) for switching between windows as it should (e.g. the help window), but not between tabs (i.e. documents). As long as we have both tabs and windows, there should be a shortcut for both, I think. alt-arrow used to work at some stage for navigating tabs, but not in the latest build.

On firefox it is ctrl-tab for tabs, alt-tab for windows (and on os x, cmd-tab for applications).

@bagong
Copy link
Contributor

bagong commented Mar 23, 2015

But I want to use alt-tab to look out of the window!

@telephon
Copy link
Member

yes, alt-tab is window-switching. Is that what you meant?

@bagong
Copy link
Contributor

bagong commented Mar 24, 2015

Haha, github has no proper emoticons yet. I think everybody is getting a notification, so maybe better continue by email :)

sofakid pushed a commit to sofakid/supercollider that referenced this pull request Apr 6, 2015
…ocswitch-fix

scide: DocumentSelectPopUp - convert to Popup to fix lost KeyRelease event
@timblechmann timblechmann deleted the topic/scide-docswitch-fix branch July 26, 2015 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants