-
Notifications
You must be signed in to change notification settings - Fork 758
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
plugins: Linen checks for prehistoric release message #1255
Conversation
Does it make sense to test the branch? How do I do that? Any test cases available? |
When setting the source of a NodeProxy repeatedly and very quickly, the gate = 0 would arrive before the synth was actually running. Now this can be avoided by sending a release time (< -1.0). This fixes #1246.
tested branch, currently it does not fix the issue described in #1246.
|
Now it does! |
I'll try :) |
works, tested also for |
This is the only potentially intrusive fix in this branch - EnvGate could, since it had the Impulse.ar(0) added to the gate input, be released with gate = 0 even in the same block the synth was created. This was added a while ago to avoid hanging synths in node proxy. Now it needs to be released with a gate <= -1 in the first block, and the node proxy does this. On the other hand, it can now be started with gate = 0 and started later.
This commit undoes the call of check_gate in EnvGen_Ctor, as it is called in next_k anyway.
The whole thing turned out to be even simpler, it is only
|
…ease plugins: Linen checks for prehistoric release message
This small change should fix the numerous and long-standing issues with synth release messages that arrive in the same block as the synth, such as #1063, and #1246.