-
Notifications
You must be signed in to change notification settings - Fork 758
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
boost updates & cmake modernization #1166
boost updates & cmake modernization #1166
Conversation
* use std::atomic instead of boost::atomic * use boost::sync::semaphore instead of nova::semaphore
use sources and MACOSX_PACKAGE_LOCATION to generate bundle & copy binaries with a POST_BUILD step
I get this build error: |
|
|
Thanks! Now this: |
Thanks! Getting close :) |
Okay, builds now, and seems to work. Thanks! Two issues:
And a final question: there used to be the option to build with non-bundled libsndfile. Is that still the case? |
Probably not so good if examples/ is inside the bundle. The bundle is essentially private and not directly accessed by users, and examples needs to be user discoverable and accessible. Some info on what should go into app bundles here: https://developer.apple.com/library/mac/documentation/corefoundation/conceptual/cfbundles/BundleTypes/BundleTypes.html |
Signed-off-by: Tim Blechmann <tim@klingt.org>
Works for me now, thanks! |
Yes, looks perfect AFAICS. I'm happy to merge this if nobody has any concerns. Thanks Tim. |
Aliases from classes and help folders into userAppSupportDir/Extensions do not work anymore. This is likely to upset some maccers, especially as helpfiles in class-folders integrated via LanguageConfig are not recognized by SCDoc (symbolic links work) |
@bagong my changes did not affect the handling of filesystem aliases. any of those upset people are more than welcome to look into the code and provide a fix. |
Ah, ok. I just bumped into this again and thought it might be related. Sorry for the noise... |
boost updates & cmake modernization
the following patches