Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

macOS: some app bundle contents are unexpectedly unwriteable #5222

Closed
mossheim opened this issue Oct 27, 2020 · 2 comments
Closed

macOS: some app bundle contents are unexpectedly unwriteable #5222

mossheim opened this issue Oct 27, 2020 · 2 comments
Labels
bug Issues that relate to unexpected/unwanted behavior. Don't use for PRs. comp: build CMake build system os: macOS

Comments

@mossheim
Copy link
Contributor

Environment

  • SuperCollider version: 3.11.2-rc1
  • Operating system: macOS
  • Other details (Qt version, audio driver, etc.): Qt 5.15.1

Steps to reproduce

Only appears as a problem when running xattr -rc

Expected vs. actual behavior

Unlike previous releases, the following files inside the QtWebEngineProcess.app bundle are given permissions 444 instead of 644: Contents/{Info.plist,PkgInfo,Resources/*}. this is because permissions on these files are not changed by the Qt 5.15.1 deploy step in the build system. it's an easy fix.

This is mainly an inconvenience for me as release manager, I have to run an extra command before signing. It generally doesn't affect users on macOS, the one case it might pop up is when trying to un-quarantine the app, but one can work around it by running xattr as sudo instead.

this doesn't affect the 3.11.2-rc1 release, but we should fix it for 3.11.2.
@mossheim mossheim added bug Issues that relate to unexpected/unwanted behavior. Don't use for PRs. os: macOS comp: build CMake build system labels Oct 27, 2020
@dyfer
Copy link
Member

dyfer commented Oct 31, 2020

What would be a proposed fix for this? change the permissions with chmod in the fixup_bundle stage of the build?

@mossheim
Copy link
Contributor Author

yep: https://github.com/supercollider/supercollider/blob/develop/editors/sc-ide/CMakeLists.txt#L541-L544

(also note my ironic comment)

@mossheim mossheim mentioned this issue Nov 1, 2020
Merged
4 tasks
@mossheim mossheim closed this as completed Nov 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Issues that relate to unexpected/unwanted behavior. Don't use for PRs. comp: build CMake build system os: macOS
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dyfer @mossheim