Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

classlib: Git.checkForGit doesn't have a return value #3445

Closed
mossheim opened this issue Jan 19, 2018 · 0 comments
Closed

classlib: Git.checkForGit doesn't have a return value #3445

mossheim opened this issue Jan 19, 2018 · 0 comments
Labels
comp: class library SC class library good first issue indicates issue tickets that are suitable for a new contributor
Milestone
3.9.1

Comments

@mossheim
Copy link
Contributor

The documentation says:

returns true, if the git toolchain is found on the system.

However, the method is missing a return statement.
@mossheim mossheim added comp: class library SC class library good first issue indicates issue tickets that are suitable for a new contributor labels Jan 19, 2018
@mossheim mossheim added this to the 3.9.1 milestone Jan 19, 2018
@mossheim mossheim mentioned this issue Jan 20, 2018
Merged
munshkr added a commit to munshkr/supercollider that referenced this issue Jan 20, 2018
@munshkr
classlib: add missing return statement on Git.checkForGit (fix superc…
8a8c4a8 
…ollider#3445)
@munshkr munshkr mentioned this issue Jan 20, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
comp: class library SC class library good first issue indicates issue tickets that are suitable for a new contributor
Projects
None yet
Milestone
3.9.1
Development

No branches or pull requests
2 participants
@patrickdupuis @mossheim