Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SC-IDE] Visual indicator if file is edited or not #317

Closed
miguel-negrao opened this issue May 7, 2012 · 3 comments
Closed

[SC-IDE] Visual indicator if file is edited or not #317

miguel-negrao opened this issue May 7, 2012 · 3 comments

Comments

@miguel-negrao
Copy link
Member

Show visually if file needs saving or not.

Change text to "*TheFIleName" on the tab, i.e. add asterisk ?

@jleben
Copy link
Member

jleben commented May 8, 2012

At the moment, that's solved by adding the "save" icon (usually a floppy disk) next to the file name. The icon is probably only displayed on Linux though, because we use the Qt's feature to get the icon from the system icon theme, but OS X and Windows apparently don't play by that game.

See QIcon::fromTheme[1] and freedesktop icon naming specification [2]

One solution is probably to use QStyle::standardIcon [3] instead of QIcon::fromTheme.

[1] http://qt-project.org/doc/qt-4.8/qicon.html#fromTheme
[2] http://standards.freedesktop.org/icon-naming-spec/icon-naming-spec-latest.html
[3] http://qt-project.org/doc/qt-4.8/qstyle.html#standardIcon

@jleben
Copy link
Member

jleben commented May 16, 2012

Hopefully, this is fixed now, in 58cdacc
There should be an icon next to the modified document's name.

If it's still not fixed on OS X, please re-open. In that case, we'll either need a custom icon shipped with SC, or represent the modification differently (for example textually, like filename or [filename] or filename)

@jleben jleben closed this as completed May 16, 2012
@miguel-negrao
Copy link
Member Author

Confirmed working on OSX.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants