Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EnvirGui calls this.widgets but has none #2371

Closed
telephon opened this issue Oct 2, 2016 · 5 comments
Closed

EnvirGui calls this.widgets but has none #2371

telephon opened this issue Oct 2, 2016 · 5 comments
Assignees
@adcxyz
Labels
bug Issues that relate to unexpected/unwanted behavior. Don't use for PRs. comp: class library SC class library comp: JITlib
Milestone
3.8

Comments

@telephon
Copy link
Member

telephon commented Oct 2, 2016

There is no instance variable widgets anywhere, but it is called by two methods:

  • EnvirGui.updateSliderSpecs
  • NdefParamGui.updateSliderSpecs

e.g.:

updateSliderSpecs { |editKeys|
        var currState;

        if (object.isNil) { specs.clear; ^this };

        currState = object.getKeysValues;

        editKeys.do { |key, i|
            var currValue = currState.detect { |pair| pair[0] == key }[1];
            var newSpec = this.getSpec(key, currValue);
            var widge = this.widgets[i];
            if (newSpec != specs[key]) {
                specs.put(key, newSpec);
                if (widge.isKindOf(EZSlider) or:
                    { widge.isKindOf(EZRanger) }) {
                    widge.controlSpec = newSpec;
                    widge.value_(currValue);
                };
            };
        }
    }

It throws the error:

ERROR: Message 'widgets' not understood.
RECEIVER:
Instance of NdefParamGui {    (0x11d09aaf8, gc=CC, fmt=00, flg=00, set=05)
@telephon telephon added this to the 3.8 milestone Oct 2, 2016
@telephon telephon added bug Issues that relate to unexpected/unwanted behavior. Don't use for PRs. comp: class library SC class library comp: JITlib labels Oct 2, 2016
@jamshark70
Copy link
Contributor

62a8dd1

But f8b56a3 appears to have removed references to widgets from the main class library... are you sure the currently-offending methods are defined in the class library, and not in the JITLibExtensions quark? I reported the JITLibExtensions bug probably, oh, a year ago, still unfixed.

@crucialfelix
Copy link
Member

Doesn't look updateSliderSpecs is in the main library at all: https://github.com/supercollider/supercollider/search?utf8=%E2%9C%93&q=updateSliderSpecs&type=Code

@telephon
Copy link
Member Author

telephon commented Oct 3, 2016

Oh dear, yes. This should go to the JITLibExtensions, sorry for the noise.

@telephon telephon closed this as completed Oct 3, 2016
@telephon telephon mentioned this issue Oct 3, 2016
Closed
@telephon
Copy link
Member Author

telephon commented Oct 3, 2016

Part of the problem seems to be that issues reported on Quarks don't show up in the notifications.

@jamshark70
Copy link
Contributor

Part of the problem seems to be that issues reported on Quarks don't show up in the notifications.

I'd vote for notifications going to quark authors, but let's not send all notices to the dev list for every quark everywhere.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@adcxyz adcxyz

Labels
bug Issues that relate to unexpected/unwanted behavior. Don't use for PRs. comp: class library SC class library comp: JITlib
Projects
None yet
Milestone
3.8
Development

No branches or pull requests
4 participants
@crucialfelix @jamshark70 @telephon @adcxyz