-
Notifications
You must be signed in to change notification settings - Fork 761
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
s.makeGui server window broken in master #2202
Comments
It's the |
My refactored status watcher hasn't been merged, @crucialfelix wanted to be careful and incremental. I am now not sure, however, what is the best way to proceed. |
Post a PR with a bug fix please. That's the whole with huge unreadable PRs - even with spending hours with it something like that gets through. I'm not sure it it was something I missed or something in the original PR. |
@crucialfelix I can try, but I don't think I can reimplement the whole recording pause-update-etc. thing in the IDE. It was already over my head, and I won't be able to do it all over. I understand that the PR was too big, but it just became that way and I had no way of simplifying it. I guess better to just throw it away, even if it was several day's work. |
Isn't the bug reported above just one small missing change ? It isn't getting the status. The whole recording pause-update thing is separate. The rest of what you did is still waiting in that old PR to be cherry picked into a new smaller PR for each feature. If you (or me or somebody) starts from master now, that person can see what things are already merged in. I basically just did the first feature and then stopped. I'll try to look at the issue above, but I'm pretty busy right now. |
OK, yes I see. |
Is this fixed? I can't reproduce on the current master. the only thing that seems missing is that the |
I can reproduce. In particular, avg CPU, number of synths, etc. aren't displaying. |
Ah ok, I can reproduce this, too. I didn't look at them, because I misunderstood the issue description. |
Apologies for vagueness in the issue description. I had thought it would be clear from the screenshot that it should be inconsistent to have a server GUI showing "running" status while all the data fields are empty. Then again, I guess nobody is using the server GUI anymore so it may have been forgotten how it works. |
No problem! Yes, I also think it would be better to make a new GUI once the refactoring is done. If it is OK even with the recording quirk, this would fix it. |
@jamshark70 your change seems to fix it. Will submit a PR now. |
Server is running. IDE server panel is updating. Server window is not updating.
I guess the new server status watcher is not finished yet?
The text was updated successfully, but these errors were encountered: