Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HIDdef.element forwards arguments incorrectly #2090

Closed
jamshark70 opened this issue May 16, 2016 · 6 comments
Closed

HIDdef.element forwards arguments incorrectly #2090

jamshark70 opened this issue May 16, 2016 · 6 comments
Labels
bug Issues that relate to unexpected/unwanted behavior. Don't use for PRs. comp: class library SC class library
Milestone
3.7.2

Comments

@jamshark70
Copy link
Contributor

https://github.com/supercollider/supercollider/blob/master/SCClassLibrary/Common/Control/HIDFunc.sc#L543 appears to be a typo. key should not be passed to HIDFunc.element.
@jamshark70 jamshark70 added bug Issues that relate to unexpected/unwanted behavior. Don't use for PRs. comp: class library SC class library labels May 16, 2016
@jamshark70 jamshark70 added this to the 3.7.2 milestone May 17, 2016
@jamshark70
Copy link
Contributor Author

Suggesting 3.7.2 -- it'll be a dirt simple fix for a method that can't function correctly under any circumstances at present.

@sensestage
Copy link
Contributor

ok, seems like an easy fix.
Please apply it :)

@sensestage
Copy link
Contributor

closed via #2105

@sensestage
Copy link
Contributor

needs backportin to 3.7 branch?

@jamshark70
Copy link
Contributor Author

I submitted the PR for 3.7. It needs to be merged forward into 3.8.

@crucialfelix
Copy link
Member

when 3.7.2 is released (very shortly) then it will be merged into master and you will see it. we may change that release branching policy with 3.8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Issues that relate to unexpected/unwanted behavior. Don't use for PRs. comp: class library SC class library
Projects
None yet
Milestone
3.7.2
Development

No branches or pull requests
3 participants
@sensestage @crucialfelix @jamshark70