Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Quarks: update fail when missing tag or no new version number #1735

Closed
redFrik opened this issue Nov 23, 2015 · 1 comment
Closed

Quarks: update fail when missing tag or no new version number #1735

redFrik opened this issue Nov 23, 2015 · 1 comment
Assignees
@crucialfelix
Labels
bug Issues that relate to unexpected/unwanted behavior. Don't use for PRs. comp: sclang sclang C++ implementation (primitives, etc.). for changes to class lib use "comp: class library" quarks
Milestone
3.7.0

Comments

@redFrik
Copy link
Contributor

redFrik commented Nov 23, 2015

trying to install LATEST version of the Conductor quark.
Quarks.gui -> check for updates -> select Conductor -> select LATEST -> click install...

Removing path: /Users/asdf/Library/Application Support/SuperCollider/downloaded-quarks/Conductor
Installing Conductor
WARNING: Tag not found: Quark: Conductor[1] 953ea218642ed1235c257c3036c596c78942f64
Possible tags: [ ]
Adding path: /Users/asdf/Library/Application Support/SuperCollider/downloaded-quarks/Conductor
Conductor installed

but no. the old version is still there.
@telephon
Copy link
Member

Yes, I can confirm this behavior, the latest changes are not there.:

set { arg ... args; // pairs of keys or indices and value
        nodeMap.set(*args);
        if(this.isPlaying) { 
            server.sendBundle(server.latency, [15, group.nodeID] ++ args); 
        };
        this.changed(\set, args);
    }

should be:

            server.sendBundle(server.latency, [15, group.nodeID] ++ args.asOSCArgArray

@crucialfelix crucialfelix added bug Issues that relate to unexpected/unwanted behavior. Don't use for PRs. comp: sclang sclang C++ implementation (primitives, etc.). for changes to class lib use "comp: class library" quarks labels Nov 24, 2015
@crucialfelix crucialfelix self-assigned this Nov 24, 2015
@crucialfelix crucialfelix added this to the 3.7.0 milestone Nov 24, 2015
crucialfelix added a commit to crucialfelix/supercollider that referenced this issue Dec 6, 2015
@crucialfelix
fix: supercollider#1735 Quarks: update fail when missing tag or no ne…
d1538bc 
…w version number

Was incorrectly chopping off the last 2 characters of the output of
`git rev-parse HEAD`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@crucialfelix crucialfelix

Labels
bug Issues that relate to unexpected/unwanted behavior. Don't use for PRs. comp: sclang sclang C++ implementation (primitives, etc.). for changes to class lib use "comp: class library" quarks
Projects
None yet
Milestone
3.7.0
Development

No branches or pull requests
3 participants
@crucialfelix @telephon @redFrik