Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FreqScope doesn't work #1527

Closed
ceremona opened this issue Jun 6, 2015 · 4 comments
Closed

FreqScope doesn't work #1527

ceremona opened this issue Jun 6, 2015 · 4 comments
Labels
bug Issues that relate to unexpected/unwanted behavior. Don't use for PRs. good first issue indicates issue tickets that are suitable for a new contributor
Milestone
3.7.x

Comments

@ceremona
Copy link

ceremona commented Jun 6, 2015

Running 10.8 OSX

s=Server.internal;
s.boot;
FreqScope(server:s)

Leads to:

-> internal
booting internal
Found 0 LADSPA plugins
Number of Devices: 13
0 : "Built-in Microph"
1 : "Built-in Output"
2 : "Soundflower (2ch)"
3 : "Soundflower (64ch)"
4 : "Premiere Pro 7.0"
5 : "Instant On Sound Effects"
6 : "Default IN/OUT"
7 : "iMic In / System Out"
8 : "Scarlett In / System Out"
9 : "RC-505 In/System Out"
10 : "Scarlet In/Bluetooth Out"
11 : "System In / Scarlett Out"
12 : "Steinberg In/Out"

"Built-in Microph" Input Device
Streams: 1
0 channels 2

"Built-in Output" Output Device
Streams: 1
0 channels 2

SC_AudioDriver: sample rate = 96000.000000, driver's block size = 512
-> internal
Receiving notification messages from server internal
Shared memory server interface initialized
Execution warning: Class 'Scope' not found
ERROR: Message 'new' not understood.
RECEIVER:
nil
ARGS:
Instance of Window { (0x115ac38a8, gc=58, fmt=00, flg=00, set=03)
instance variables [5]
resizable : false
drawFunc : nil
view : instance of TopView (0x11a2bbef8, size=35, set=6)
acceptsClickThrough : false
currentSheet : nil
}
Instance of Rect { (0x11a1b3be8, gc=54, fmt=00, flg=00, set=02)
instance variables [4]
left : Integer 30
top : Integer 14
width : Integer 522
height : Integer 300
}
CALL STACK:
DoesNotUnderstandError:reportError 0x115979d38
arg this =
Nil:handleError 0x1159a8ae8
arg this = nil
arg error =
Thread:handleError 0x11597d958
arg this =
arg error =
Object:throw 0x11597cd98
arg this =
Object:doesNotUnderstand 0x11597baf8
arg this = nil
arg selector = 'new'
arg args = [_2]
FreqScopeView:initFreqScope 0x115268ef8
arg this =
arg parent =
arg bounds =
arg argServer =
Meta_FreqScope:new 0x11a0773d8
arg this =
arg width = 522
arg height = 300
arg busNum = 0
arg scopeColor =
arg bgColor = nil
arg server =
var rect =
var scope = nil
var window =
var pad = [_4]
var font =
var freqLabel = [_12]
var freqLabelDist = 47.454545454545
var dbLabel = [_17]
var dbLabelDist = 18.75
var setFreqLabelVals =
var setDBLabelVals =
var nyquistKHz = 48
Interpreter:interpretPrintCmdLine 0x11552b6b8
arg this =
var res = nil
var func =
var code = "FreqScope(server:s)"
var doc = nil
var ideClass =
Process:interpretPrintCmdLine 0x115ab16e8
arg this =
^^ The preceding error dump is for ERROR: Message 'new' not understood.
RECEIVER: nil
@scztt scztt added bug Issues that relate to unexpected/unwanted behavior. Don't use for PRs. good first issue indicates issue tickets that are suitable for a new contributor labels Jun 6, 2015
@scztt scztt added this to the 3.7 milestone Jun 6, 2015
@scztt
Copy link
Contributor

scztt commented Jun 6, 2015

Hmm - so, one problem is, this is referencing Scope instead of SCScope, which is what that class is named currently. The SCScope name is probably wrong, and.... possible needs to be named Scope instead? And, beyond that, it's picking to use Scope versus ScopeView based on shmScopeAvailable, which in turn is checking: and: { server.inProcess.not } - ScopeView works fine for both in-process and out-of-process servers afaict.

I believe the proper fix for this is:

  1. Remove the and: { server.inProcess.not } condition from shmScopeAvailable
  2. Rename all uses of Scope to SCScope
  3. Create a new "future" + "enhancement" issue to rename SCScope to something more appropriate (LegacyScope? RemoteScope?), or remove if it's not needed anymore.

@ceremona - Want to give the above changes (1 & 2) a go, and see if it fixes scope for both local and internal servers - if it does, make a pull request!

@ceremona
Copy link
Author

ceremona commented Jun 7, 2015

Sorry. My SC foo is not strong enough to understand what you are saying for step 1.

adcxyz added a commit that referenced this issue Jun 18, 2015
@adcxyz
fix scope on internal, solves #1527
fa6c53b
@adcxyz
Copy link
Contributor

adcxyz commented Jun 18, 2015

ok, submitted a PR for this. test:

Server.default = s = Server.internal; s.boot;
FreqScope(server: s);
{ SinOsc.ar(LFNoise0.kr((3..12)).exprange(20, 20000)).mean }.play;

telephon added a commit that referenced this issue Jun 23, 2015
@telephon
Merge pull request #1552 from supercollider/fix_SCScope_on_internal
8102c1c 
fix scope on internal, solves #1527
@telephon
Copy link
Member

Fixed by fa6c53b

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Issues that relate to unexpected/unwanted behavior. Don't use for PRs. good first issue indicates issue tickets that are suitable for a new contributor
Projects
None yet
Milestone
3.7.x
Development

No branches or pull requests
4 participants
@scztt @ceremona @telephon @adcxyz