-
Notifications
You must be signed in to change notification settings - Fork 757
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scsynth zombie when quitting scide #1456
Comments
I am not working or compiling scide so forgive my ignorance:
|
For me it doesn't happen on OS X, but on Ubuntu 15.04/Qt5.21 and Windows too |
I cant find the code quiting the server from the ide exit. |
It seems sclang closes open servers automatically on exit. At least that's what happens in OS X if I quit sclang running in a terminal. Maybe sclang isn't unloaded properly on Windows and Linux? I vaguely remember some error-reports in that direction... |
Yes, I just tried on Ubuntu:
On Windows this cannot be tested because the readline interface doesn't work. |
@bagong Same here (archlinux) |
The same here, Debian 64bit, scide compiled against Qt 5.3.2, not sure what commit is causing this, but it is quite recent commit (two week or so), I am rebuilding master branch quite often nowadays. |
Haha, if it were Windows I'd try to identify it ;) Maybe someone else? If it's really only 2 weeks old you'd only need 4 or so builds. But my feeling is the reports on this are quite a bit older... |
It is quite recent behaviour.. I was looking into recent history, recompiled few times, and it seems to me the bug happens after this merge: 0f5abf4. |
Great find! maybe @sonoro1234 has an idea. And maybe his PR #1445 helps here? Could you try? |
Hah, it's gone with the PR. Interestingly sclang still borks on close. But the server is shut down. So two apparently unrelated issues, haha. |
I tried this on Ubuntu only, can't do it on Windows atm. |
pull request #1318 but the response was to merge Best solution could be to apply #1445 to finish the work (or revert third commit of this merge if this dont solves the issue) |
Is the sclang issue also related to pull request #1318? |
There was already this issue 10 day before the merge |
The first email is from the 21st of March, not related to your commit: |
Does PR #1445 helps with sclang problem? |
No ;) |
So, what shall we do? |
My feeling is merge #1445 as quickly as possible, but have one or two guru's have an eye on it. Or do you want to create a separate PR for that commit? It's possible... |
Will fixing the supernova crash on OS X take a long time? |
I added a commit in #1445 for that. |
I retract that remark ;) |
yes |
The proper way is to pull master from github sc repo and then push it to your own repo. This is a monster commit. It probably boils down to nothing when merged into master, but this is really intransparent. So I assume you can only interact with your own sc-repo when working with git locally, right? |
yes, I made local file modifications, commit and push |
I am not sure how to compare that commit with sc-master. Some diffing would be required. The way you are working, the relation between the sc github repo and your sc repo will get more and more intransparent and messy.
What does that pull-request #1 refer to? |
I did a pull request in my fork with "compare forks" |
Thanks for all your help |
You're welcome! |
I have made the gitjub changes and PR #1465 |
Great man, thanks for your dedication! |
Good job guys, thanks for developing Supercollider! |
see #1467. Please test! Works for me with Ubuntu... |
Well, I am sorry, I cannot confirm bugfix in my case, 87e26cd tested.. then:
still gives me:
It seems some zombies are still walking around (even after proper ScIde shutdown), my specs now are:
|
Thank you for testing! There is a line in your description I wonder about:
As you found out, the commit you are referring to is the one that introduced the bug. Rather than just reverting that commit, @sonoro1234 is still trying to enhance plugins unload.
There are various ways how to test pull requests. The one I like most is described at the end of the sc git cheatsheet: https://github.com/supercollider/supercollider.github.io/blob/master/development/git-cheat-sheet.md |
Oops you're right.. my deep appologize. #1467 merged, compiled, the bug still presist.
I may also make some mistake during the merge, as it can't be done automagically, so I have done it by hand. |
You mean you needed to fix merge conflicts? That likely means you didn't use latest vanilla master as merge base. @sonoro and I have been applying this repeatedly and never had a merge conflict. So maybe check your master? Possibly you have merged something else that conflicts? Or more likely: you didn't update master to the latest ( |
Yes, there were conflict during merge, is there any vanilla master? I thought I am on latest master branch by default.. |
Maybe you haven't synchronized it with master for some time? Or did you merge anything else into it? |
Hm probably not, I should be up to date.. latest master cloned Am I doing something wrong? |
The problem is I cannot reproduce this, which means if done properly there shouldn't be merge conflicts... To detect a mistake I'd have to see the commands you used. If you didn't get a "cannot resolve origin/pr/1467" error, the problem can only be the state of your master. As you seem to have tried to merge pr/1467 into master it seems likely that you have some old stuff in there as well. It's not good practice to merge anything into master. You should create a dedicated branch off master first, and merge into that branch. Am I guessing into the right direction? |
Ok, trying to figure out..
|
So you are running this as a bash-script? I am not sure if you get error-messages from earlier lines in that case. I am also not sure about depth one and that stuff, for me the easiest has always been to say I am pretty sure the mistake occurs after you added the pr/* line to your git-config. After that you have to do
otherwise the pr's you want to merge won't be there (adding the line to the config file only creates a reference, nothing is downloaded). And then, I also don't see where you merged the branch. When would the manual merging you talked about have happened? so the missing steps are (after your sed line):
And apart from that better practice would be something like:
and then continue with the creation of build folder etc: BTW: if you still see
in the post-window after s.quit, that means the PR has not been applied. |
Wait, now I seem to see something else in the gist than I saw before... ;) Did you change it, or did I have halucinations? :) Maybe we should communicate some other way. These threads are posted to everybody following the SC repo... |
Yes, sorry for spamming whole community.. |
what's your name? |
Thanks for staying on the ball and testing, Krystof! |
Can we close? |
The issue can be closed, to, right? @gusano |
@bagong Yes. Thanks! |
Description
After quitting scide,
scsynth
process stays alive.Reproducer
s.boot
s.boot
gives the following error:
Exception in World_OpenUDP: bind: Address already in use
Platform, version
The text was updated successfully, but these errors were encountered: