-
Notifications
You must be signed in to change notification settings - Fork 757
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Quarks windows path error bug #1451
Comments
It seems to be trying to do an initial fetch of the quarks directory and failing. Maybe it tried to do that before downloaded-quarks was created ? but that is done during *initClass
@bagong does this path exist: C:\Users\Rainer\AppData\Local\SuperCollider\downloaded-quarks\ can you post the directory listing |
Yes, it does, how could the first Quark (MathLib) install successfully, if it didn't. Here steps without anything done with Quarks.gui:
Note that the path issue referring to the "quarks" folder only occurs if I open Quarks.gui and no Quark has been installed yet. If I open Quarks.gui and a Quark is already installed, the error will refer to the installed Quark, e.g.:
|
OK, now I can trace the bug. thanks ! its Quarks.isPath that needs to use a different regex for window it does not detect that its a path // is this true ? On Tue, May 5, 2015 at 2:16 PM Rainer Schütz notifications@github.com
|
No, it's a symbol. thisProcess.platform.name == \windows // or 'windows' are true |
Okay, I can confirm that replacing the regex in isPath with something that returns true removes the error produced above. I think it's quite tricky to create a robust regex that recognizes a path. Windows path's usually start with a drive letter. There could also be network-paths starting with Just in case, the Regex I used (which just covers my local case) is: But getting true from isPath turns up another error: First of all the "Recompile class library" button never get's active. So I close, recompile manually and restart the Quarks.gui. The gui does not show which Quarks that have been installed. It is still possible to install Quarks that haven't been installed yet, but trying to reinstall a Quark that has already been installed returns this in the post window:
|
rather than try to make a single reg-ex that matches both *nix and windows, it was an omission on my part in that method. will fix it anything that uses *isPath is going to have a problem on windows until its On Tue, May 5, 2015 at 5:48 PM Rainer Schütz notifications@github.com
|
How would you do that in sclang? |
I'm 99.9% sure this fixes it. If I reverse the if-statement (thus making OS X fail to parse a path correctly) I can see the exact bug and call stack you posted. Better would be a unit test but I didn't have time to set that up. |
Reported by @bagong :
This is an unlucky overlap of different issues. The basic parse error is still there. Currently is it as follows:
ERROR: C:\Users\Rainer\AppData\Local\SuperCollider\downloaded-quarks\MathLib not found
quarks
folder is created and populated properly) and then fail as posted below.
It seems Quarks can't read path's on Windows. Including/Excluding folders in preferences works as expected.
The text was updated successfully, but these errors were encountered: