Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch for minor 'links' bug in scvim_make_help #141

Closed
jleben opened this issue May 6, 2012 · 2 comments
Closed

Patch for minor 'links' bug in scvim_make_help #141

jleben opened this issue May 6, 2012 · 2 comments
Labels
bug Issues that relate to unexpected/unwanted behavior. Don't use for PRs. env: scvim
Milestone

Comments

@jleben
Copy link
Member

jleben commented May 6, 2012

[Issue migrated from SourceForge | ID: 3080798 | Submitted by 'mtheo5']
[http://sourceforge.net/support/tracker.php?aid=3080798]

The script editors/scvim/bin/scvim_make_help never closes IO.popen(...) when it runs the command links (instead unhtml).
In this way it exceeds the maximum number of file descriptors that the processes may open, it blocks itself and some other processes.
I attach a patch to solve it.

Matteo Quintiliani

--- editors/scvim/bin/scvim_make_help(revision 10372)
+++ editors/scvim/bin/scvim_make_help(working copy)
@@ -175,7 +175,9 @@

def myunhtml(infile,outfile)
if $uselinks

  • lines = IO.popen("links -dump -width 128 'file://#{infile}'").readlines
  • fp = IO.popen("links -dump -width 128 'file://#{infile}'", "r")
  • lines=fp.readlines
  • fp.close_read
    #remove annoying spaces at beg of each line, first see if they are there
    hasAnnoyingSpaces = true
    lines.each do |line|
@timblechmann
Copy link
Contributor

mayb some vim users can check, if this is still valid?

@danstowell
Copy link
Member

This script no longer exists (since b6f2ef3).

So thanks to the submitter, but this is no longer needed.

mossheim added a commit that referenced this issue Aug 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issues that relate to unexpected/unwanted behavior. Don't use for PRs. env: scvim
Projects
None yet
Development

No branches or pull requests

3 participants