Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use reader/writer thread for all disk IO (DiskIn / DiskOut ugens, others if applicable) #1381

Closed
scztt opened this issue Mar 28, 2015 · 2 comments
Closed

Use reader/writer thread for all disk IO (DiskIn / DiskOut ugens, others if applicable) #1381

scztt opened this issue Mar 28, 2015 · 2 comments
Labels
enhancement
Milestone
3.8

Comments

@scztt
Copy link
Contributor

scztt commented Mar 28, 2015

If disk writes are slow or delayed, DiskOut can easily corrupt a recording. A separate IO thread should be used, with reads (DiskIn) and write (DiskOut) requests queued and performed asynchronously. Possibly the supernova implementation can be borrowed or adapted.
@scztt scztt added this to the 3.8 milestone Mar 28, 2015
@muellmusik
Copy link
Contributor

I'm not sure I understand. There is a separate IO thread, or? PR #1382 deals with the issue discussed in the thread that this arose from.

@scztt
Copy link
Contributor Author

scztt commented Mar 28, 2015

You're right - I reviewed your change and the disk io ugens as they are and I don't know if there's more improvement to be had, barring specific performance bugs.

@scztt scztt closed this as completed Mar 28, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
3.8
Development

No branches or pull requests
2 participants
@scztt @muellmusik