Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

quarks (new) - installing local quark does not install it's dependencies it only links. #1378

Closed
miguel-negrao opened this issue Mar 27, 2015 · 1 comment
Labels
bug Issues that relate to unexpected/unwanted behavior. Don't use for PRs. quarks

Comments

@miguel-negrao
Copy link
Member

    *install { |name, refspec|
        var path;
        if(Quarks.isPath(name).not, {
            this.installQuark(Quark(name, refspec));
        }, {
            // local path / ~/ ./
            path = this.asAbsolutePath(name);
            if(File.exists(path).not, {
                ("Path does not exist" + path).warn;
            });
            this.link(path);
        });
    }

Shouldn't the behaviour be the same if the quark is local or not ? Perhaps *installQuark could be modified to also install local quarks, by not doing a checkout on those, but still running the rest of the code, like getting the dependencies.

@crucialfelix
Copy link
Member

This was fixed in 4581a35

@crucialfelix crucialfelix added bug Issues that relate to unexpected/unwanted behavior. Don't use for PRs. quarks labels Jan 17, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issues that relate to unexpected/unwanted behavior. Don't use for PRs. quarks
Projects
None yet
Development

No branches or pull requests

2 participants