Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LFPar and LFCub audio rate modulation frequency argument bug #127

Closed
jleben opened this issue May 6, 2012 · 1 comment
Closed

LFPar and LFCub audio rate modulation frequency argument bug #127

jleben opened this issue May 6, 2012 · 1 comment
Labels
bug Issues that relate to unexpected/unwanted behavior. Don't use for PRs. comp: scsynth

Comments

@jleben
Copy link
Member

jleben commented May 6, 2012

[Issue migrated from SourceForge | ID: 2994009 | Submitted by 'nobody']
[http://sourceforge.net/support/tracker.php?aid=2994009]

{LFPar.ar(XLine.kr(300, 500, 10), 0, 0.5)}.play
{LFPar.ar(XLine.ar(300, 500, 10), 0, 0.5)}.play//silent

{LFCub.ar(XLine.kr(300, 500, 10), 0, 0.5)}.play
{LFCub.ar(XLine.ar(300, 500, 10), 0, 0.5)}.play//silent

@jleben
Copy link
Member Author

jleben commented May 6, 2012

[Comment migrated from SourceForge | Submitted by 'danstowell']

For me this patch (below) fixes the issue with LFPar. However, the analogous tweak doesn't fix LFCub. Anyone know why?

Index: common/Source/plugins/LFUGens.cpp

--- common/Source/plugins/LFUGens.cpp (revision 10114)
+++ common/Source/plugins/LFUGens.cpp (working copy)
@@ -635,7 +635,9 @@
float z = phase;
ZXP(out) = 1.f - z*z;

            }
  •           phase += ZXP(freq) \* freqmul;
    
  •           // Note: the following two lines were originally one, but seems to compile wrong on mac
    
  •           float phaseadd = ZXP(freq) \* freqmul;
    
  •           phase += phaseadd;
    );
    
    unit->mPhase = phase;
    

@jleben jleben closed this as completed May 6, 2012
mossheim pushed a commit that referenced this issue Aug 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issues that relate to unexpected/unwanted behavior. Don't use for PRs. comp: scsynth
Projects
None yet
Development

No branches or pull requests

1 participant