Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BlockSize UGen not working due to typo Blocksize -> BlockSize #1180

Closed
rd-- opened this issue Aug 26, 2014 · 3 comments
Closed

BlockSize UGen not working due to typo Blocksize -> BlockSize #1180

rd-- opened this issue Aug 26, 2014 · 3 comments
Labels
bug Issues that relate to unexpected/unwanted behavior. Don't use for PRs.

Comments

@rd--
Copy link
Contributor

rd-- commented Aug 26, 2014

The class library defines a BlockSize UGen but the plugin is called Blocksize so it doesn't work.

{SinOsc.ar(BlockSize.ir * 5) * 0.1}.play

The UGen is undocumented, & I think this error means no one has tried to use it.

Which means the plugin can be renamed to make it work?

(That's what i've done here and it's fine...)

The edit is trivial, but copied below.

Best,
rd

diff --git a/server/plugins/DelayUGens.cpp b/server/plugins/DelayUGens.cpp
index 30caf5b..0175f10 100644
--- a/server/plugins/DelayUGens.cpp
+++ b/server/plugins/DelayUGens.cpp
@@ -498,7 +498,7 @@ void RadiansPerSample_Ctor(Unit *unit, int inNumSamples)
        ZOUT0(0) = unit->mWorld->mFullRate.mRadiansPerSample;
 }

-void Blocksize_Ctor(Unit *unit, int inNumSamples)
+void BlockSize_Ctor(Unit *unit, int inNumSamples)
 {
        ZOUT0(0) = unit->mWorld->mFullRate.mBufLength;
 }
@@ -7735,7 +7735,7 @@ PluginLoad(Delay)
        DefineInfoUnit(ControlDur);
        DefineInfoUnit(SubsampleOffset);
        DefineInfoUnit(RadiansPerSample);
-       DefineInfoUnit(Blocksize);
+       DefineInfoUnit(BlockSize);
        DefineInfoUnit(NumInputBuses);
        DefineInfoUnit(NumOutputBuses);
        DefineInfoUnit(NumAudioBuses);
@timblechmann
Copy link
Contributor

i guess with a pull request, it is more likely to get fixed.

@rd-- rd-- mentioned this issue Oct 18, 2014
Merged
@rd--
Copy link
Contributor Author

rd-- commented Oct 18, 2014

"K. felt slightly abandoned..."

ref: #1206

@muellmusik
Copy link
Contributor

Sorry K. Thanks for the fix.

@crucialfelix crucialfelix changed the title Blocksize -> BlockSize BlockSize UGen not working due to typo Blocksize -> BlockSize Jan 18, 2016
@crucialfelix crucialfelix added the bug Issues that relate to unexpected/unwanted behavior. Don't use for PRs. label Jan 18, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Issues that relate to unexpected/unwanted behavior. Don't use for PRs.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@crucialfelix @timblechmann @muellmusik @rd--