Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NdefMixer clips output channel to 99 #1096

Closed
muellmusik opened this issue May 2, 2014 · 6 comments
Closed

NdefMixer clips output channel to 99 #1096

muellmusik opened this issue May 2, 2014 · 6 comments
Labels
bug Issues that relate to unexpected/unwanted behavior. Don't use for PRs.

Comments

@muellmusik
Copy link
Contributor

It is possible for Ndefs to play to higher busses by code but the GUI clips to 99.
@muellmusik muellmusik added the bug label May 2, 2014
@telephon
Copy link
Member

telephon commented May 2, 2014

The limit is just a default:
MonitorGui.lastOutBus = 99;
But it may really be better to derive this value from the server options.

@muellmusik
Copy link
Contributor Author

Yes, that would make sense.

On 2 May 2014, at 18:46, Julian Rohrhuber notifications@github.com wrote:

The limit is just a default:
MonitorGui.lastOutBus = 99;
But it may really be better to derive this value from the server options.

—
Reply to this email directly or view it on GitHub.

@muellmusik
Copy link
Contributor Author

Probably it should be the last private audio bus? It is sometimes useful to play Ndefs out private busses

@telephon
Copy link
Member

telephon commented May 4, 2014

Definitely yes - you can use play to rout between private busses, too.
So that would be: numPrivateAudioBusChannels + numInputBusChannels + numOutputBusChannels

telephon pushed a commit that referenced this issue May 6, 2014
class library: jitlib gui: derive lastOutBus from default server options
0889447 
This is just a preliminary solution, a refactoring of the gui classes will improve this. Fixes issue #1096.
@muellmusik
Copy link
Contributor Author

So can this be closed? Or should it remain open to encourage the better fix?

@telephon
Copy link
Member

telephon commented May 8, 2014

Can be closed for now...

@telephon telephon closed this as completed May 8, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Issues that relate to unexpected/unwanted behavior. Don't use for PRs.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@muellmusik @telephon