Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: define command options function before use #6375

Merged
merged 1 commit into from
Nov 27, 2024

Conversation

ferrarimarco
Copy link
Collaborator

@ferrarimarco ferrarimarco commented Nov 20, 2024

Define functions in linterCommands.sh to avoid the need of exporting them. Without this fix, a command that sourced linterCommands.sh would not be able to find these functions, such as AddOptionsToCommand.

Fix #6372

Readiness checklist

In order to have this pull request merged, complete the following tasks.

Pull request author tasks

  • I checked that all workflows return a success.
  • I included all the needed documentation for this change.
  • I provided the necessary tests.
  • I squashed all the commits into a single commit.
  • I followed the
    Conventional Commit v1.0.0 spec.
  • I wrote the necessary upgrade instructions in the
    upgrade guide.
  • If this pull request is about and existing issue, I added the
    Fix #ISSUE_NUMBER or Close #ISSUE_NUMBER text to the description of
    the pull request.

Super-linter maintainer tasks

  • Label as breaking if this change breaks compatibility with the previous
    released version.
  • Label as either: automation, bug, documentation, enhancement,
    infrastructure.
  • Add the pull request to a milestone, eventually creating one, that matches
    with the version that release-please proposes in the
    preview-release-notes CI job.

@ferrarimarco ferrarimarco added bug Something isn't working O: backlog 🤖 Backlog, stale ignores this label labels Nov 20, 2024
@ferrarimarco ferrarimarco added this to the 7.2.1 milestone Nov 20, 2024
@ferrarimarco ferrarimarco force-pushed the fix-command-not-found branch 2 times, most recently from 8e69d9b to 499235c Compare November 27, 2024 08:47
Define functions in linterCommands.sh to avoid the need of exporting
them. Without this fix, a command that sourced linterCommands.sh would
not be able to find these functions, such as AddOptionsToCommand.

Fix #6372
@ferrarimarco ferrarimarco merged commit 6b60f4c into main Nov 27, 2024
161 checks passed
@ferrarimarco ferrarimarco deleted the fix-command-not-found branch November 27, 2024 13:33
@ferrarimarco ferrarimarco mentioned this pull request Dec 5, 2024
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working O: backlog 🤖 Backlog, stale ignores this label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AddOptionsToCommand: command not found
1 participant