Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update nextjs-todo-list guide and config.toml #30716

Merged
merged 12 commits into from
Dec 4, 2024
Merged

chore: update nextjs-todo-list guide and config.toml #30716

merged 12 commits into from
Dec 4, 2024

Conversation

avallete
Copy link
Member

I have read the CONTRIBUTING.md file.

YES

What kind of change does this PR introduce?

  • Update the config.toml for the nextjs/todolist example.
  • Update the README.md to mention the different development environments setups (local / remote / preview).

@vercel Vercel
Copy link

vercel bot commented Nov 28, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
design-system ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 4, 2024 8:59am
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 4, 2024 8:59am
studio-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 4, 2024 8:59am
zone-www-dot-com ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 4, 2024 8:59am
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
studio ⬜️ Ignored (Inspect) Visit Preview Dec 4, 2024 8:59am
studio-self-hosted ⬜️ Ignored (Inspect) Visit Preview Dec 4, 2024 8:59am

@supabase Supabase
Copy link

supabase bot commented Nov 28, 2024

This pull request has been ignored for the connected project xguihxuzqibwxjnimxev because there are no changes detected in supabase directory. You can change this behaviour in Project Integrations Settings ↗︎.

Preview Branches by Supabase.
Learn more about Supabase Branching ↗︎.

sweatybridge
sweatybridge reviewed Nov 28, 2024
View reviewed changes
Copy link
Contributor

@sweatybridge sweatybridge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall. Need a second opinion from devrel

examples/todo-list/nextjs-todo-list/supabase/config.toml Outdated Show resolved Hide resolved
examples/todo-list/nextjs-todo-list/README.md Outdated Show resolved Hide resolved
@vercel vercel bot temporarily deployed to Preview – docs December 3, 2024 09:08 Inactive
@vercel vercel bot temporarily deployed to Preview – zone-www-dot-com December 3, 2024 09:08 Inactive
@sweatybridge sweatybridge enabled auto-merge (squash) December 4, 2024 08:53
@sweatybridge sweatybridge merged commit d265797 into master Dec 4, 2024
12 checks passed
@sweatybridge sweatybridge deleted the chore/update-todolist-example-config branch December 4, 2024 08:59
avallete added a commit that referenced this pull request Dec 4, 2024
@avallete @sweatybridge
chore: update nextjs-todo-list guide and config.toml (#30716)
2fa2ce0 
* chore: update nextjs-todo-list guide and config.toml

* fix: use commented vercel urls

* Update examples/todo-list/nextjs-todo-list/supabase/config.toml

Co-authored-by: Han Qiao <sweatybridge@gmail.com>

* Update examples/todo-list/nextjs-todo-list/supabase/config.toml

Co-authored-by: Han Qiao <sweatybridge@gmail.com>

* chore(docs): remove local development guide

* chore(docs): document dotenv usage syntax

* chore: complete auth config example

* chore: update config comments

* chore: disable seeding via config

---------

Co-authored-by: Han Qiao <sweatybridge@gmail.com>
Co-authored-by: Qiao Han <qiao@supabase.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sweatybridge sweatybridge sweatybridge approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@avallete @sweatybridge