Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore/move advisors #30283

Merged
merged 4 commits into from
Nov 5, 2024
Merged

Chore/move advisors #30283

merged 4 commits into from
Nov 5, 2024

Conversation

saltcod
Copy link
Contributor

@saltcod saltcod commented Nov 4, 2024

  • moves Query Performance to Advisors
  • renames Security → Security Advisor, Performance → Performance Advisor to be less werid with "Query Performance"
  • makes the schema visualizer the top level item under /database/

@saltcod saltcod requested a review from a team as a code owner November 4, 2024 19:44
@vercel Vercel
Copy link

vercel bot commented Nov 4, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 5, 2024 9:24am
studio-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 5, 2024 9:24am
zone-www-dot-com ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 5, 2024 9:24am
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
design-system ⬜️ Ignored (Inspect) Visit Preview Nov 5, 2024 9:24am
studio ⬜️ Ignored (Inspect) Visit Preview Nov 5, 2024 9:24am
studio-self-hosted ⬜️ Ignored (Inspect) Visit Preview Nov 5, 2024 9:24am

@supabase Supabase
Copy link

supabase bot commented Nov 4, 2024

No changes detected in supabase directory.
This pull request has been ignored for the connected project xguihxuzqibwxjnimxev due to its connection settings.
Go to Project Integrations Settings ↗︎ in order to change this behavior.

Preview Branches by Supabase.
Learn more about Supabase Branching ↗︎.

@vercel vercel bot temporarily deployed to Preview – docs November 5, 2024 09:11 Inactive
@vercel vercel bot temporarily deployed to Preview – zone-www-dot-com November 5, 2024 09:11 Inactive
joshenlim
joshenlim approved these changes Nov 5, 2024
View reviewed changes
Copy link
Member

@joshenlim joshenlim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Verified changes on the preview 🙂

@joshenlim joshenlim merged commit dd4788b into master Nov 5, 2024
15 checks passed
@joshenlim joshenlim deleted the chore/move-advisors branch November 5, 2024 09:25
zackproser-workos pushed a commit to zackproser-workos/supabase that referenced this pull request Nov 13, 2024
@saltcod @joshenlim @zackproser-workos
Chore/move advisors (supabase#30283)
5c004a4 
* Move advisory things to Advisors page, move schema visualizer to top of database section

* Tiny clean up

* Tiny clean up

---------

Co-authored-by: Joshen Lim <joshenlimek@gmail.com>
encima pushed a commit that referenced this pull request Nov 19, 2024
@saltcod @joshenlim @encima
Chore/move advisors (#30283)
35525ee 
* Move advisory things to Advisors page, move schema visualizer to top of database section

* Tiny clean up

* Tiny clean up

---------

Co-authored-by: Joshen Lim <joshenlimek@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshenlim joshenlim joshenlim approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@saltcod @joshenlim