Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add custom-metadata to upload #328

Merged
merged 1 commit into from
Dec 30, 2024
Merged

feat: add custom-metadata to upload #328

merged 1 commit into from
Dec 30, 2024

Conversation

silentworks
Copy link
Collaborator

@silentworks silentworks commented Dec 25, 2024 •
edited
Loading

What kind of change does this PR introduce?

  • Add custom metadata on upload
  • Fix warnings tests were giving with pytest-asyncio

What is the current behavior?

Please link any relevant issues here.

What is the new behavior?

Custom Metadata

Adds support for custom metadata on objects:

storage.from_(bucketName).upload(uploadPath, file, {
        "metadata": {
          "custom": "metadata",
          "second": "second",
          "third": "third",
        },
})

Additional context

Relates to supabase/storage#439
#295
supabase/storage-js#207

@silentworks silentworks requested review from grdsdev and J0 December 25, 2024 16:41
@silentworks silentworks linked an issue Dec 25, 2024 that may be closed by this pull request
Add support for custom metadata, new info and exists method #295
Closed
J0
J0 approved these changes Dec 30, 2024
View reviewed changes
Copy link
Contributor

@J0 J0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@silentworks silentworks merged commit d4f9794 into main Dec 30, 2024
12 checks passed
@silentworks silentworks deleted the silentworks/custom-metadata branch December 30, 2024 11:57
@github-actions github-actions bot mentioned this pull request Dec 30, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@J0 J0 J0 approved these changes

@grdsdev grdsdev Awaiting requested review from grdsdev

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for custom metadata, new info and exists method
2 participants
@silentworks @J0