ptch: add x-upsert header to upsert duplicate object #32
Conversation
ankitjena
force-pushed
the
feat/upsert-object-api
branch
from
791839a to
1d23047
Compare
|
Hey Ankit, this looks good! There seems to be a type error and can you add tests for the upsert mode too? |
I think upgrading the |
Ah cool, lets upgrade postgrest-js also in this PR then. |
Should I upgrade it to the latest version, from the repo I see |
…ing upsert method
ankitjena
force-pushed
the
feat/upsert-object-api
branch
from
49f5b7c to
b4a8913
Compare
|
Yup, that version should be fine. I don't think there were any breaking changes. |
|
The tests are failing for some reason. Not related to the test suites though. |
|
I ran the tests locally and they seem to be fine @ankitjena. I will debug why the Github actions are failing separately. Thanks for your contribution ❤️ |
|
Also @inian Should I create a issue in |
|
Do you want to help with this too Ankit? supabase/storage-js#7 (comment) |
Sure do |
What kind of change does this PR introduce?
feature
What is the current behavior?
Closes #21
Currently insert throws a duplicate key error when trying to insert an key that already exists.
What is the new behavior?
Adds a
x-upsertheader to the insert object api, which upserts the object when the value of the header istrue.Screen recording