fix: add custom error classes #341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
silentworks
reviewed
Aug 3, 2022
This was referenced Aug 3, 2022
J0
reviewed
Aug 3, 2022
J0
reviewed
Aug 3, 2022
| @@ -697,9 +697,9 @@ export default class GoTrueApi { | |||
| } | |||
| const { event, session } = req.body | |||
|
|
|||
| if (!event) throw new Error('Auth event missing!') | |||
| if (!event) throw new AuthEventMissingError() | |||
There was a problem hiding this comment.
More a question than a review comment: when will we have auth events go missing? Not too sure how the events portion works.
If there's time, can I trouble you for a short overview pre/post sync?
J0
approved these changes
Aug 3, 2022
|
🎉 This PR is included in version 1.23.0-next.7 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 2.0.0-rc.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
AuthErrorinstead of throwing a generic error