Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: polishing the worker bootstrap phase and ridding annoying cache adaptor errors emitted from transformers.js #453

Merged
merged 2 commits into from
Nov 29, 2024

Conversation

nyannyacha
Copy link
Collaborator

@nyannyacha nyannyacha commented Nov 28, 2024

What kind of change does this PR introduce?

Miscellaneous

Description

November cleanup.

FYI @kallebysantos , you can access the debug variable through the internals.

import { internals } from 'ext:core/mod.js';

// in debug build
console.log(internals.bootstrapArgs.opts.debug); // true

What's change

  • Now, DenoRuntime invokes the globalThis.bootstrapSBEdge function directly instead of invoking it through execute_script.
  • All the arguments passed to globalThis.bootstrapSBEdge are objectified. They are no longer arrays, which will allow for more flexibility when we are adding flags in the future.
  • Fixes an issue where annoying error messages were emitted due to an exception propagated by cache_adaptor.js when transformers.js accessed the Cache API.

@laktek
Copy link
Contributor

laktek commented Nov 28, 2024

Can you update the PR title and description with high-level overview of the main refactors? Would be handy in future, if we want to trace back to a change

@nyannyacha
Copy link
Collaborator Author

Since the PR isn't finished yet, I'll change the title when I finish it.

- not throwing Cache Adapter errors when is `debug`

(cherry picked from commit 1396d42)
@nyannyacha nyannyacha changed the title fix: november cleanup fix: polishing the worker bootstrap phase and ridding annoying cache adaptor errors emitted from transformers.js Nov 28, 2024
@laktek laktek self-requested a review November 29, 2024 04:52
@nyannyacha nyannyacha merged commit 18d8f69 into supabase:main Nov 29, 2024
3 checks passed
@nyannyacha nyannyacha deleted the fix-nov-cleanup branch November 29, 2024 04:54
Copy link

🎉 This PR is included in version 1.65.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants