Add topic guide describing rsun idiosyncracies
#7000
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cadair
reviewed
May 9, 2023
|
This will conflict with #6954. I would suggest merging that first since it does additional reorganization as well. It may be that all of the info in that (very incomplete) topic guide is completely redundant compared to the more complete information here. |
|
The other PR is now merged. |
alasdairwilson
force-pushed
the
add_rsun_topic
branch
from
84c9ed8 to
1338f93
Compare
nabobalis
reviewed
May 30, 2023
|
It unfortunately conflicts with main as well now. |
ayshih
reviewed
May 30, 2023
There was a problem hiding this comment.
I don't want to block this PR, but here is the structure and content this topic guide eventually needs to have, which could be deferred to a follow-up PR:
- The title should be something like "Different values for the radius of the Sun"
- There ought to be an introduction that explains the radius of the Sun:
Observing in visible wavelengths
The meaning and context of the IAU constant
Observing in wavelengths other than visible (e.g., EUV)
- The second section should describe the
rsunframe attribute
2D coordinates
Converting 2D coordinates to 3D coordinates, with examples
- The third section should describe how the radius of the Sun is determined for data files
RSUN_REF keyword, or calculated from RSUN_OBS keyword, or default
Why Maps from different data sources might have different `rsun` values for the same emission
Why the precise value of the radius of the Sun typically doesn't matter
- The fourth section then goes into reprojection
Cadair
approved these changes
Jun 7, 2023
nabobalis
reviewed
Jun 7, 2023
|
We should create a tracking issue for Alberys comment. |
alasdairwilson
force-pushed
the
add_rsun_topic
branch
2 times, most recently
from
75ffa2d to
28a68e9
Compare
Co-authored-by: Nabil Freij <nabil.freij@gmail.com>
Co-authored-by: Stuart Mumford <stuart@cadair.com>
Co-authored-by: Nabil Freij <nabil.freij@gmail.com>
alasdairwilson
force-pushed
the
add_rsun_topic
branch
from
28a68e9 to
dba438e
Compare
nabobalis
force-pushed
the
add_rsun_topic
branch
3 times, most recently
from
93230a5 to
e8d0d22
Compare
nabobalis
approved these changes
Jun 7, 2023
meeseeksmachine
pushed a commit
to meeseeksmachine/sunpy
that referenced
this pull request
Jun 8, 2023
nabobalis
pushed a commit
that referenced
this pull request
Jun 8, 2023
…idiosyncracies) (#7056) Co-authored-by: Alasdair Wilson <60351846+alasdairwilson@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This takes some of the content from coords regarding rsun and its involvement in transforms/reprojects expands on it and makes a topic guide.
If anyone else can think of additional content that should be here and feedback on current content extremely welcome.