Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ruff PR 2 #6961

Merged
merged 2 commits into from
Apr 25, 2023
Merged

Ruff PR 2 #6961

merged 2 commits into from
Apr 25, 2023

Conversation

dstansby
Copy link
Member

@dstansby dstansby commented Apr 24, 2023

I'm going to pull stuff out of #6836 into several PRs that build on each other for easier review. Here's the second one. This enables flake8 fixes.

@dstansby dstansby force-pushed the ruff-2 branch 2 times, most recently from e2ab866 to acd4eb6 Compare April 24, 2023 19:01
@dstansby dstansby added this to the 5.0.0 milestone Apr 25, 2023
@dstansby dstansby added No Changelog Entry Needed Skip any changelog checks. No Backport A PR that isn't to be backported to any release branch. (To be used as a flag to other maintainers) labels Apr 25, 2023
Copy link
Member Author

@dstansby dstansby Apr 25, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test deleted here are duplicates

@dstansby dstansby marked this pull request as ready for review April 25, 2023 14:55
@dstansby dstansby requested review from a team as code owners April 25, 2023 14:55
@nabobalis nabobalis merged commit 43fe92c into sunpy:main Apr 25, 2023
@dstansby dstansby deleted the ruff-2 branch April 25, 2023 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
No Backport A PR that isn't to be backported to any release branch. (To be used as a flag to other maintainers) No Changelog Entry Needed Skip any changelog checks.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants