Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean cibuildwheel config #6952

Merged
merged 2 commits into from
Apr 26, 2023
Merged

Clean cibuildwheel config #6952

merged 2 commits into from
Apr 26, 2023

Conversation

dstansby
Copy link
Member

@dstansby dstansby commented Apr 23, 2023 •
edited
Loading

  • Copy some config to pyproject.toml
  • Enable testing on Python 3.11
  • Remove openCV pin (the issue that caused us to pin it should be fixed now)

@dstansby dstansby added No Changelog Entry Needed Skip all changelog checks. No Backport A PR that isn't to be backported to any release branch. (To be used as a flag to other maintainers) Run publish Run publish CI on this PR. labels Apr 23, 2023
@dstansby
Copy link
Member Author

Hmm, for some reason cibuildwheel isn't picking up the config in pyproject.toml

@dstansby
Copy link
Member Author

🎉 wheel tests are being run and passing on Python 3.11

@dstansby dstansby marked this pull request as ready for review April 23, 2023 19:31
@dstansby dstansby added this to the 5.0.0 milestone Apr 23, 2023
ConorMacBride
ConorMacBride reviewed Apr 23, 2023
View reviewed changes
Copy link
Member

@ConorMacBride ConorMacBride left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've opened OpenAstronomy/github-actions-workflows#127 which should allow the test_extras and test_command workflow inputs to be removed. Although, we'll still need these inputs for the sdist and pure Python wheel jobs.

pyproject.toml Outdated Show resolved Hide resolved
Cadair
Cadair requested changes Apr 25, 2023
View reviewed changes
Copy link
Member

@Cadair Cadair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need the other build fails to get out of the way for this to run the publish step.

dstansby and others added 2 commits April 26, 2023 12:05
@dstansby @Cadair
Clean up cibuildhweel config
d2a4d1f
@dstansby @ConorMacBride @Cadair
Fix test extras
7224a5f 
Co-authored-by: Conor MacBride <conor@macbride.me>
Cadair
Cadair approved these changes Apr 26, 2023
View reviewed changes
Copy link
Member

@Cadair Cadair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me as long as all the CI passes, including publish.

@Cadair Cadair added the Merge When CI Passes Hit that merge button when it's all green. label Apr 26, 2023
@Cadair
Copy link
Member

Cadair commented Apr 26, 2023

wow, a completely green CI run, that never happens.

@Cadair Cadair merged commit a3e5dc6 into sunpy:main Apr 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ConorMacBride ConorMacBride ConorMacBride left review comments

@Cadair Cadair Cadair approved these changes

@nabobalis nabobalis nabobalis approved these changes

Assignees
No one assigned
Labels
Merge When CI Passes Hit that merge button when it's all green. No Backport A PR that isn't to be backported to any release branch. (To be used as a flag to other maintainers) No Changelog Entry Needed Skip all changelog checks. Run publish Run publish CI on this PR.
Projects
None yet
Milestone
5.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@dstansby @Cadair @nabobalis @ConorMacBride