Clean up time tutorial #6920
Merged
Clean up time tutorial #6920
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nabobalis
reviewed
Apr 16, 2023
nabobalis
reviewed
Apr 16, 2023
dstansby
added
the
No Backport
nabobalis
previously approved these changes
Apr 18, 2023
This comment was marked as resolved.
This comment was marked as resolved.
wtbarnes
reviewed
Apr 24, 2023
wtbarnes
reviewed
Apr 24, 2023
wtbarnes
reviewed
Apr 24, 2023
wtbarnes
reviewed
Apr 24, 2023
wtbarnes
reviewed
Apr 24, 2023
wtbarnes
reviewed
Apr 24, 2023
wtbarnes
requested changes
Apr 24, 2023
There was a problem hiding this comment.
I agree that this is an improvement over what was here previously, but I think this section of the tutorial could still do with some major restructuring. Currently, it still is in a more how-to format than tutorial. In particular, I think this section could be structured in three sections:
- Parsing time
- Arithmetic with time
- Time ranges
In section 1, we could parse two times (from different formats), perform some (very basic) arithmetic with them in section 2, and then construct a time range from them in section 3.
We are pretty late in the game for 5.0 so if these changes feel like to much for this PR, I'm ok punting this larger rewrite to 5.1.
Co-authored-by: Nabil Freij <nabil.freij@gmail.com>
wtbarnes
approved these changes
Apr 27, 2023
Co-authored-by: Will Barnes <will.t.barnes@gmail.com>
nabobalis
approved these changes
Apr 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6863. Not perfect, but a lot better and good enough for 5.0 I think.