Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore: Typos fixed in multiple files #99

Merged
merged 2 commits into from
Oct 13, 2023
Merged

Chore: Typos fixed in multiple files #99

merged 2 commits into from
Oct 13, 2023

Conversation

SusheelThapa
Copy link
Contributor

This pull request fix the typo that has been seen in multiple files.

Structual > Structural
statment > statement
modifiying > modifiying
hava > have
begining > beginning
Javacript > Javascript
recomended > recommended

@vercel
Copy link

vercel bot commented Oct 13, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
learn-javascript ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 13, 2023 4:32pm

@SusheelThapa
Copy link
Contributor Author

@sumn2u Can you please review this pull request?

sumn2u
sumn2u reviewed Oct 13, 2023
View reviewed changes
Copy link
Owner

@sumn2u sumn2u left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love the changes. Is it possible to rename the Javascript to JavaScript?

en/browser-object-model-bom/cookies.md Outdated
@@ -18,19 +18,19 @@ book = Learn Javascript
The `document.cookie` property is used to create, read and delete cookies. Creating cookie is pretty easy you need to provide the name and value

```javascript
document.cookie = "book=Learn Javacript";
document.cookie = "book=Learn Javascript";
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If possible can you rename this Javascript to JavaScript?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure why not?

@SusheelThapa
Copy link
Contributor Author

@sumn2u Can you please review it again?

sumn2u
sumn2u approved these changes Oct 13, 2023
View reviewed changes
Copy link
Owner

@sumn2u sumn2u left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sumn2u sumn2u merged commit d226eb5 into sumn2u:main Oct 13, 2023
@SusheelThapa SusheelThapa deleted the patch-1 branch October 14, 2023 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sumn2u sumn2u sumn2u approved these changes

Assignees

@SusheelThapa SusheelThapa

Labels
hacktoberfest hacktoberfest-accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SusheelThapa @sumn2u