Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I have added content to interview questions basic and advanced section #78

Merged
merged 3 commits into from
Oct 11, 2023

Conversation

kumar007ambi
Copy link
Contributor

#74 I want to add some more contents in Interview Questions

@vercel
Copy link

vercel bot commented Oct 10, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
learn-javascript ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 11, 2023 2:55pm

@kumar007ambi
Copy link
Contributor Author

@sumn2u Please review this PR

Copy link
Owner

@sumn2u sumn2u left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The content looks good. Would it be possible to exclude the package-lock.json and yarn.lock files from this pull request?

@kumar007ambi
Copy link
Contributor Author

@sumn2u okay I will remove it from the PR

@kumar007ambi
Copy link
Contributor Author

@sumn2u I have added yarn.lock and package-lock.json to gitignore

Copy link
Owner

@sumn2u sumn2u left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sumn2u sumn2u merged commit 5221944 into sumn2u:main Oct 11, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants