Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

French translation #54

Merged
merged 13 commits into from
Oct 3, 2023
Merged

French translation #54

merged 13 commits into from
Oct 3, 2023

Conversation

scheuerkev
Copy link
Contributor

Hi !
Here you can find a first bunch in french translations. As you can see, I've performed i18n settings in relevant JSON global files.
:)
Regards

@vercel
Copy link

vercel bot commented Oct 3, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
learn-javascript ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 3, 2023 0:34am

Copy link
Owner

@sumn2u sumn2u left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for translating these chapters into French. Appreciated your work.


{% hint style="warning" %}
La méthode `forEach()` n'est pas exécutée dans le cas d'une instruction vide.
{% endenta %}
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, this one is an internal tag and shouldn't be translated. Can you change it back to {% endhint %}?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My pleasure ! Sorry for this ! Changed back and commited 🚀

Copy link
Owner

@sumn2u sumn2u left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sumn2u sumn2u merged commit 18f9534 into sumn2u:main Oct 3, 2023
1 check passed
@sumn2u
Copy link
Owner

sumn2u commented Oct 3, 2023

This PR fixes #56 issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants