Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write space and time complexity chapter #114

Merged
merged 2 commits into from
Oct 31, 2023

Conversation

starvader13
Copy link
Contributor

@starvader13 starvader13 commented Oct 15, 2023

This MR aims to solve issue #112

Considering space and time complexity is a significant aspect of programming that ensures code efficiency, scalability, and maintainability. Having a brief introduction to these concepts, followed by example, can greatly benefit JavaScript developers.

Signed-off-by: starvader13 <ashutoshgupta1311@gmail.com>
Signed-off-by: starvader13 <ashutoshgupta1311@gmail.com>
@vercel
Copy link

vercel bot commented Oct 15, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
learn-javascript ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 15, 2023 5:59am

@starvader13
Copy link
Contributor Author

@sumn2u Can you have a look if I am going on to the right path or not ?

@starvader13 starvader13 marked this pull request as draft October 15, 2023 06:01
@sumn2u
Copy link
Owner

sumn2u commented Oct 18, 2023

@sumn2u Can you have a look if I am going on to the right path or not ?

Looking great. If possible can you describe O(log n) and O(n^2) too?

@starvader13
Copy link
Contributor Author

Looking great. If possible can you describe O(log n) and O(n^2) too?

Roger that! I will add code snippets for that.

Been busy with some work. I will ping you with the updated changes

@starvader13
Copy link
Contributor Author

Been busy with some work. I will ping you with the updated changes

Starting with the work from today. Thanks for being patient with me @sumn2u

@sumn2u
Copy link
Owner

sumn2u commented Oct 31, 2023

Hey @starvader13, today is the last day of Hacktoberfest. Do you think you can create a pull request by the end of the day?

@starvader13
Copy link
Contributor Author

Hey @starvader13, today is the last day of Hacktoberfest. Do you think you can create a pull request by the end of the day?

Should I divide it into two PRs, if possible?? You can accept this change for now and the rest I can change it in the next PR.

Or if this is not possible we can move forward with this without considering it for Hacktoberfest and I will push the changes ASAP.

@starvader13 starvader13 marked this pull request as ready for review October 31, 2023 15:25
@sumn2u
Copy link
Owner

sumn2u commented Oct 31, 2023

Hey @starvader13, today is the last day of Hacktoberfest. Do you think you can create a pull request by the end of the day?

Should I divide it into two PRs, if possible?? You can accept this change for now and the rest I can change it in the next PR.

Or if this is not possible we can move forward with this without considering it for Hacktoberfest and I will push the changes ASAP.

If it's going to easier for you to split, i suggest to split. If not it's ok to have it in a single PR.

@sumn2u sumn2u merged commit 04d556a into sumn2u:main Oct 31, 2023
1 check passed
@sumn2u
Copy link
Owner

sumn2u commented Oct 31, 2023

@starvader13 You can add your create another PR with remaining contents.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants