date formatting #104
Merged
date formatting #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
i assume coverage will jump a bit once this is merged to a master branch that contains @ndushay's splitting out of tests that need powermockito. |
…acing * make WasapiDownloaderSettings.settings protected instead of private * TestWasapiDownloaderSettings.getSettingsErrorMessages_listsAllErrors creates a regular (non-spy) WasapiDownloaderSettings instance and injects a filled-in Properties instance instead of mocking accessor method returns. * java.lang stuff is imported by default
…lized version of the date (in a format we know the WASAPI endpoint accepts) * replace isValidIso8601String with normalizeIso8601Setting and normalizeIso8601StringForEndpoint * test normalizeIso8601Setting
jmartin-sul
force-pushed
the
49-date-formatting
branch
from
c51d88f to
5fc233a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes sul-dlss/web-archiving#49
third commit contains an example of what i was thinking of in the second thing i mentioned here (about writing to
System.err): #102 (review)