Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PHP] Fix quoted PHP strings in tag attributes #3471

Merged
merged 1 commit into from
Aug 13, 2022
Merged

[PHP] Fix quoted PHP strings in tag attributes #3471

merged 1 commit into from
Aug 13, 2022

Conversation

deathaxe
Copy link
Collaborator

@jfcherng
Copy link
Collaborator

jfcherng commented Aug 13, 2022 •
edited
Loading

Just curious about why with_prototype gives
image
while this PR works.

@deathaxe
Copy link
Collaborator Author

Given that with_prototype also ignores meta_include_prototype: false it appears to work fundamentally different than normal prototype. Also cache size of smaller examples differ much when comparing both mechanisms.

@deathaxe deathaxe merged commit f69c683 into sublimehq:master Aug 13, 2022
@deathaxe deathaxe deleted the pr/php/fix-php-tags-in-strings branch August 13, 2022 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jfcherng jfcherng jfcherng approved these changes

@michaelblyons michaelblyons michaelblyons approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@deathaxe @jfcherng @michaelblyons