enable storing of media queries in variables #776
Merged
+11
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -188,6 +188,8 @@ Evaluator.prototype.visitReturn = function(ret){ | |||
|
|
|||
| Evaluator.prototype.visitMedia = function(media){ | |||
| media.block = this.visit(media.block); | |||
| var query = this.lookup(media.val); | |||
| if(query) media.val = this.lookup("unquote").fn.call(this,query.nodes[0]); | |||
There was a problem hiding this comment.
LGTM tho we can just do if (query) media.val = new nodes.Literal(query.nodes[0].string) to avoid the lookup / .call
|
good idea, implemented. |
tj
added a commit
that referenced
this pull request
Aug 7, 2012
enable storing of media queries in variables
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's common to reuse the same media queries throughout a stylesheet. It makes sense to use variables to keep track of these media queries, so you only have to update them in one place. Currently stylus ignores any variables used after the @media block. This change fixes that, so the following now works:
I've added a new test for this, and all other tests still pass.