Fix custom-property-empty-line-before false positives for CSS-in-JS
#6767
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change fixes the `isFirstNested()` utility that the `custom-property-empty-line-before` rule internally uses. The rule's test does not change in order to avoid adding an extra dependency for CSS-in-JS. See also the PostCSS API for the `Document` node: <https://postcss.org/api/#document>
🦋 Changeset detectedLatest commit: b1e2007 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
ybiquitous
commented
Apr 9, 2023
There was a problem hiding this comment.
[note] Instead of installing a custom syntax package, I wrote a naive custom syntax only for testing.
See also https://postcss.org/docs/how-to-write-custom-syntax
|
Note: Probably, this PR should be applied to not only @hudochenkov I would appreciate it if you could let me any concerns about PostCSS's CSS-in-JS syntaxes. |
|
Thanks for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6766
This change fixes the
isFirstNested()utility that thecustom-property-empty-line-beforerule internally uses.The rule's test does not change in order to avoid adding an extra dependency for CSS-in-JS.See also the PostCSS API for the
Documentnode: https://postcss.org/api/#document