Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix selector-attribute-name-disallowed-list end positions #6223

Merged
merged 1 commit into from
Jul 28, 2022
Merged

Fix selector-attribute-name-disallowed-list end positions #6223

merged 1 commit into from
Jul 28, 2022

Conversation

ybiquitous
Copy link
Member

Which issue, if any, is this issue related to?

Part of #5694

Is there anything in the PR that needs further explanation?

No, it's self-explanatory.

@ybiquitous ybiquitous force-pushed the fix-selector-attribute-name-disallowed-list-end-positions branch from a67a433 to 8201b73 Compare July 27, 2022 14:53
mattxwang
mattxwang approved these changes Jul 27, 2022
View reviewed changes
Copy link
Member

@mattxwang mattxwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Read-through + manually looking at the test cases, this looks good to me! Great work 😊

@ybiquitous ybiquitous merged commit 68e5b50 into main Jul 28, 2022
@ybiquitous ybiquitous deleted the fix-selector-attribute-name-disallowed-list-end-positions branch July 28, 2022 08:52
@ybiquitous
Copy link
Member Author

Changelog entry added:

  • Fixed: selector-attribute-name-disallowed-list end positions (#6223).

@sync-by-unito sync-by-unito bot mentioned this pull request Sep 6, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattxwang mattxwang mattxwang approved these changes

@jeddy3 jeddy3 jeddy3 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ybiquitous @jeddy3 @mattxwang