Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix no-invalid-position-at-import-rule false positives for @layer #6094

Merged
merged 2 commits into from
May 16, 2022
Merged

Fix no-invalid-position-at-import-rule false positives for @layer #6094

merged 2 commits into from
May 16, 2022

Conversation

immitsu
Copy link
Contributor

@immitsu immitsu commented May 14, 2022

Which issue, if any, is this issue related to?

Resolve #6085

Is there anything in the PR that needs further explanation?

No.

ybiquitous
ybiquitous requested changes May 15, 2022
View reviewed changes
Copy link
Member

@ybiquitous ybiquitous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@immitsu Thanks for creating the pull request. Almost LGTM 👍🏼

Can you please update the doc also "ignoring @charset"? ⬇️

stylelint/lib/rules/no-invalid-position-at-import-rule/README.md

Line 13 in a08312b

Any `@import` rules must precede all other valid at-rules and style rules in a stylesheet (ignoring `@charset`), or else the `@import` rule is invalid.

@ybiquitous ybiquitous changed the title extend if-block Fix no-invalid-position-at-import-rule false positives for @layer May 15, 2022
@immitsu
Copy link
Contributor Author

immitsu commented May 15, 2022

@ybiquitous Done!

ybiquitous
ybiquitous approved these changes May 15, 2022
View reviewed changes
Copy link
Member

@ybiquitous ybiquitous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@ybiquitous ybiquitous merged commit 1a1bbde into stylelint:main May 16, 2022
@ybiquitous
Copy link
Member

Changelog entry added:

Fixed: no-invalid-position-at-import-rule false positives for @layer (#6094).

@sync-by-unito sync-by-unito bot mentioned this pull request Jun 1, 2022
Closed
@sync-by-unito sync-by-unito bot mentioned this pull request Jul 1, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ybiquitous ybiquitous ybiquitous approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[no-invalid-position-at-import-rule] Should allow @layer to come before @import
2 participants
@immitsu @ybiquitous