Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ignoreFunctions: [] to unit-allowed-list #5857

Merged
merged 10 commits into from
Jan 22, 2022
Merged

Add ignoreFunctions: [] to unit-allowed-list #5857

merged 10 commits into from
Jan 22, 2022

Conversation

treemmett
Copy link
Contributor

Which issue, if any, is this issue related to?

Closes #5851

Is there anything in the PR that needs further explanation?

No, it's self-explanatory.

@treemmett treemmett changed the title test(unit-allowed-list): function symbols unit-allowed-list ignoreFunctions Jan 20, 2022
ybiquitous
ybiquitous reviewed Jan 21, 2022
View reviewed changes
Copy link
Member

@ybiquitous ybiquitous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@treemmett Thank you for creating the pull request! It looks almost good to me. 👍🏼

lib/rules/unit-allowed-list/__tests__/index.js Outdated Show resolved Hide resolved
ybiquitous
ybiquitous approved these changes Jan 21, 2022
View reviewed changes
Copy link
Member

@ybiquitous ybiquitous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! LGTM 👍🏼

@jeddy3 jeddy3 changed the title unit-allowed-list ignoreFunctions Add ignoreFunctions: [] to unit-allowed-list Jan 21, 2022
jeddy3
jeddy3 requested changes Jan 21, 2022
View reviewed changes
Copy link
Member

@jeddy3 jeddy3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the pull request.

I've requested a couple of changes. Looks good otherwise.

lib/rules/unit-allowed-list/README.md Outdated Show resolved Hide resolved
lib/rules/unit-allowed-list/README.md Outdated Show resolved Hide resolved
lib/rules/unit-allowed-list/index.js Outdated Show resolved Hide resolved
@treemmett
Copy link
Contributor Author

@jeddy3 Changes are added

jeddy3
jeddy3 requested changes Jan 21, 2022
View reviewed changes
Copy link
Member

@jeddy3 jeddy3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the changes.

One more request, and I think we're ready to merge.

.vscode/settings.json Outdated Show resolved Hide resolved
@treemmett treemmett requested a review from jeddy3 January 21, 2022 17:54
jeddy3
jeddy3 approved these changes Jan 22, 2022
View reviewed changes
Copy link
Member

@jeddy3 jeddy3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM!

@jeddy3 jeddy3 merged commit 7dc2aed into stylelint:main Jan 22, 2022
@jeddy3
Copy link
Member

jeddy3 commented Jan 22, 2022

  • Added: ignoreFunctions: [] to unit-allowed-list (#5857).

@treemmett treemmett deleted the unit-allowed-list branch January 23, 2022 07:22
@sync-by-unito sync-by-unito bot mentioned this pull request Jan 27, 2022
Closed
@sync-by-unito sync-by-unito bot mentioned this pull request Mar 1, 2022
Closed
@pinkhominid pinkhominid mentioned this pull request Jan 11, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeddy3 jeddy3 jeddy3 approved these changes

@ybiquitous ybiquitous ybiquitous approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add ignoreFunctions: [] to unit-allowed-list
3 participants
@treemmett @jeddy3 @ybiquitous