Add ignoreSelectors: [] to property-case
#5822
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
godested
force-pushed
the
property-case-ignore-selectors
branch
7 times, most recently
from
ee704b4 to
e871cc6
Compare
ybiquitous
reviewed
Jan 11, 2022
There was a problem hiding this comment.
@godested Thank you for creating this pull request! 👍🏼
I have some suggestions additionally:
- Please update the rule doc to add a "Optional secondary options" section:
- https://github.com/stylelint/stylelint/blob/ab6ee6689470f8212340367861f79ace9d04cfc3/lib/rules/property-case/README.md
- See also: https://github.com/stylelint/stylelint/blob/ab6ee6689470f8212340367861f79ace9d04cfc3/lib/rules/selector-max-specificity/README.md#optional-secondary-options
- Please revert the
package-lock.jsonfile that was probably committed by mistake.
jeddy3
changed the title
ignoreSelectors: [] to property-case
godested
force-pushed
the
property-case-ignore-selectors
branch
from
e871cc6 to
f5d89a3
Compare
|
@godested Can you rebase, please? |
jeddy3
approved these changes
Jan 21, 2022
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #5821
No, it's self-explanatory