Fix some tests that use callbacks #4970
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
hudochenkov
requested changes
Oct 10, 2020
| } | ||
| d {} | ||
| `; | ||
| a {} |
There was a problem hiding this comment.
Could increase all template literal content indentation by one level? So it look nicer :)
There was a problem hiding this comment.
Agreed. I'll fix the template literals in other files in another PR. 💪
| postcss.parse(css).walkRules((rule) => { | ||
| parseSelector((selectorAST) => { | ||
| selectorAST.walkPseudos(cb); | ||
| selectorAST.walkPseudos((pseudo) => pseudos.push(pseudo)); |
There was a problem hiding this comment.
Parameter pseudo is the same as function name pseudo. Maybe rename function to pseudoClass to avoid potential hard to find bugs.
There was a problem hiding this comment.
Good catch! ESLint's no-shadow rule may reduce our review cost:
$ npx eslint --rule "no-shadow: 2" lib/utils/__tests__/isContextFunctionalPseudoClass.test.js
/tmp/stylelint/lib/utils/__tests__/isContextFunctionalPseudoClass.test.js
12:29 error 'pseudo' is already declared in the upper scope no-shadow
✖ 1 problem (1 error, 0 warnings)There was a problem hiding this comment.
I've opened #4985 about the `no-shadow- rule.
hudochenkov
approved these changes
Oct 13, 2020
m-allanson
added a commit
that referenced
this pull request
Nov 5, 2020
* master: (46 commits) Update CHANGELOG.md Add ignoreAtRules to property-no-unknown (#4965) Bump eslint from 7.11.0 to 7.12.1 (#5017) Bump typescript from 4.0.3 to 4.0.5 (#5016) Bump lint-staged from 10.4.0 to 10.5.1 (#5014) Bump remark-cli from 8.0.1 to 9.0.0 (#4996) Bump jest-circus from 26.5.3 to 26.6.1 (#5009) Bump got from 11.7.0 to 11.8.0 (#5007) Bump jest from 26.5.3 to 26.6.1 (#5008) Refactor formatter tests (#4988) Fix `isStandardSyntaxDeclaration.test.js` that use callbacks (#4972) Update CHANGELOG.md Add "comment-pattern" rule (#4962) Update CHANGELOG.md Show the pattern in "*-pattern" rule messages (#4975) Enable ESLint `no-shadow` and add disable comments (#4986) Report disables in the same manner as lints (#4973) Update dependencies (#4982) Fix some tests that use callbacks (#4970) Use own vendor utility instead of PostCSS (#4942) (#4963) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the following tests that use callbacks:
lib/utils/__tests__/findAtRuleContext.test.jslib/utils/__tests__/isContextFunctionalPseudoClass.test.jslib/utils/__tests__/isMap.test.jslib/utils/__tests__/isStandardSyntaxFunction.test.jsThis is a part of #4881.
This PR includes some indentation changes, so I recommend viewing with hidden whitespace changes.