Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix false positives for longhand grid-column/row-* properties in value-keyword-case #4611

Merged
merged 2 commits into from
Feb 20, 2020
Merged

Fix false positives for longhand grid-column/row-* properties in value-keyword-case #4611

merged 2 commits into from
Feb 20, 2020

Conversation

fanich37
Copy link
Contributor

Which issue, if any, is this issue related to?

It should close #4605 .

Is there anything in the PR that needs further explanation?

I think its necessary to convert prop to lower case before any comparison can be done.

alexander-akait
alexander-akait approved these changes Feb 20, 2020
View reviewed changes
Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!

ybiquitous
ybiquitous approved these changes Feb 20, 2020
View reviewed changes
Copy link
Member

@ybiquitous ybiquitous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! LGTM 👍

@jeddy3 jeddy3 changed the title Ignore area case (#4605) Fix false positives for longhand grid-column/row-* properties in value-keyword-case Feb 20, 2020
@jeddy3 jeddy3 merged commit 014df66 into stylelint:master Feb 20, 2020
@jeddy3
Copy link
Member

jeddy3 commented Feb 20, 2020

  • Fixed: value-keyword-case false positives for longhand grid-column/row-* properties (#4611).

@fanich37 fanich37 deleted the fix/vkc-ignore-area-case branch February 20, 2020 14:36
@camiblanch
Copy link

This change caused an issue with having uppercase in css variable properties that you wish to add to the ignoreProperties list. See #4644

@jeddy3 jeddy3 mentioned this pull request Mar 12, 2020
Closed
@snyk-bot snyk-bot mentioned this pull request Mar 13, 2020
Closed
This was referenced Mar 29, 2020
Merged
Merged
This was referenced Apr 5, 2020
Closed
Closed
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexander-akait alexander-akait alexander-akait approved these changes

@ybiquitous ybiquitous ybiquitous approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix false positives for longhand grid-column-* properties in value-keyword-case
5 participants
@fanich37 @jeddy3 @camiblanch @ybiquitous @alexander-akait