-
-
Notifications
You must be signed in to change notification settings - Fork 946
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Property no unknown #4184
Property no unknown #4184
Conversation
Don't have we a problem with node 8 runner in CI? always fails in node 8 runner |
Strange error, agree, maybe concurrence |
As I understand we using windows runners, so we can use build-in images for runners, see https://www.appveyor.com/docs/windows-images-software/#node-js instead of installing node 8 manually https://github.com/stylelint/stylelint/blob/master/appveyor.yml#L19 . I am not familiar with appveyor CI/CD, but it is pretty common functionality + if we will add lock file we could install packages faster with Also one idea, we using cache from |
This will not add much time to us, but will increase the maintenance time on the project
/cc @stylelint/core what is blocker for using lock file, it is good practice |
Why it will be increased? AppVeyor is pretty popular and they maintain there images, so it will make behavior of our code expected since they create node 8 environment for us instead of using combo => unknown runner env + node 8 (If I understand how appveyor works 😁) For gitlab it is common practice |
Who will update the images? Tomorrow we may be busy and not find it at this time |
Looks like we have misunderstanding each other. How it works now:
Cost of maintenance each version add new environment How it will work with predefined images:
example config:
Cost of maintenance each version add new image in list Actually workers already have node 8 |
If I make mistake in describing it, will be great, if you will clarify for me how it works |
|
closes #4020
nothing