Don't parse ignored files #3801
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 10, 2018 14:23
CAYdenberg
approved these changes
Nov 11, 2018
|
This looks ... good. Don't know why we weren't already doing this 👍 |
jeddy3
approved these changes
Nov 12, 2018
|
@CAYdenberg Thanks for the review. I assume this is a patch and the following changelog entry will suffice?:
|
jeddy3
changed the title
ignored files before lint, to avoid parse errors
|
Yeah that looks good
…On Mon, Nov 12, 2018, 3:55 AM jeddy3 ***@***.*** wrote:
@CAYdenberg <https://github.com/CAYdenberg> Thanks for the review. I
assume this is a patch and the following changelog entry will suffice?:
- Fixed: ignored files are no longer parsed (#3801
<#3801>).
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#3801 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ADlUUEXeGXtEG48_dbBcY3qfXM9UMfLEks5uuVOSgaJpZM4YX3MT>
.
|
|
@jeddy3 When can publish a version that include this? The issue throw errors when i use stylelint with vscode 😸 |
|
We can do a release today #3826. |
|
Oh, very thanks... |
This was referenced Nov 28, 2018
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… in these files.
A replacement for #3778.
now, below codes will throw a parse error even the .stylelintignore has pattern /**
const stylelint = require('stylelint');
stylelint.lint({
code: 'var a = {',
codeFilename: 'test.js',
}).then(data => console.log(data));
because lintsource throw parse error even the file is ignored.
this PR ignore files before lint, so avoid that errors.
e.g. "No, it's self explanatory."