Fix false positives for no-descending-specificity and scss syntax #3420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeddy3
requested changes
Jun 23, 2018
|
|
||
| accept: [ | ||
| { | ||
| code: ".foo { &--a, &--a#{&}--b { div { padding: 10px; } } }" |
There was a problem hiding this comment.
Use the minimum amount of code possible to communicate the pattern e.g. if the rule targets selectors then use an empty rule e.g. {}.
Can we use the following please?:
.foo { &--a, &--a#{&}--b { div {} } }| checkSelector(s, rule, index, comparisonContext) | ||
| ); | ||
| parseSelector(resolvedSelector, result, rule, s => { | ||
| if (isStandardSyntaxSelector(resolvedSelector)) { |
There was a problem hiding this comment.
The convention, in this file and others, is to return early when using the isStandard* utils. We should probably follow it here too:
parseSelector(resolvedSelector, result, rule, s => {
if (isStandardSyntaxSelector(resolvedSelector)) {
return;
}
checkSelector(s, rule, index, comparisonContext);
}
|
This was referenced Jul 26, 2018
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3417
No.