-
-
Notifications
You must be signed in to change notification settings - Fork 942
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix false positives for at-root in indentation #3225
Fix false positives for at-root in indentation #3225
Conversation
Looks good, but how about adding a test for |
@kristerkari Thanks for your quick feedback. I added the missing reject test for both Btw every time I try to commit, your setup git hook running |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding the reject tests. LGTM
That's odd. Hopefully, it's just a glitch that'll go away. At the moment the CI is green so there are no formatting revisions to make. |
@AndyOGo Sorry for inconvenience. It will be fixed by #3232. @jeddy3 It wasn't caught by CI, because we don't run |
Oh wow. I just assumed we did as I have it set up that way for all my day-job projects. I guess we never got around to it. Let's remedy that in another PR. |
No problem, Good it turns out right :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
|
fixes #3168
No, it's self explanatory.