Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix false positives for at-root in indentation #3225

Merged
merged 4 commits into from
Mar 23, 2018

Conversation

AndyOGo
Copy link
Contributor

@AndyOGo AndyOGo commented Mar 18, 2018

Which issue, if any, is this issue related to?

fixes #3168

Is there anything in the PR that needs further explanation?

No, it's self explanatory.

@kristerkari
Copy link
Contributor

Looks good, but how about adding a test for reject too?

@AndyOGo
Copy link
Contributor Author

AndyOGo commented Mar 19, 2018

@kristerkari Thanks for your quick feedback. I added the missing reject test for both @at-root and @nest.

Btw every time I try to commit, your setup git hook running prettier complains and aborts my commit. I have to force it by --no-verify. Prettier can't autofix either and I don't see what's wrong with the code 🤔

Copy link
Member

@jeddy3 jeddy3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the reject tests. LGTM

@jeddy3
Copy link
Member

jeddy3 commented Mar 20, 2018

Btw every time I try to commit, your setup git hook running prettier complains and aborts my commit.

That's odd. Hopefully, it's just a glitch that'll go away. At the moment the CI is green so there are no formatting revisions to make.

@jeddy3 jeddy3 changed the title Feature/scss at root for indentation Fix false positives for at-root in indentation Mar 20, 2018
@hudochenkov
Copy link
Member

Btw every time I try to commit, your setup git hook running prettier complains and aborts my commit.

That's odd. Hopefully, it's just a glitch that'll go away. At the moment the CI is green so there are no formatting revisions to make.

@AndyOGo Sorry for inconvenience. It will be fixed by #3232.

@jeddy3 It wasn't caught by CI, because we don't run npm run prettier:check in CI :)

@jeddy3
Copy link
Member

jeddy3 commented Mar 20, 2018

@jeddy3 It wasn't caught by CI, because we don't run npm run prettier:check in CI :)

Oh wow. I just assumed we did as I have it set up that way for all my day-job projects. I guess we never got around to it. Let's remedy that in another PR.

@AndyOGo
Copy link
Contributor Author

AndyOGo commented Mar 20, 2018

No problem, Good it turns out right :)
I really loved my dev experience 😃

Copy link
Member

@hudochenkov hudochenkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@jeddy3 jeddy3 merged commit 3be193c into stylelint:master Mar 23, 2018
@jeddy3
Copy link
Member

jeddy3 commented Mar 23, 2018

  • Fixed: indentation false positives for at-root (#3225).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

False positives for at-rules within selectors lists in indentation
4 participants