First pass at fix #2744
Merged
First pass at fix #2744
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwilsson
approved these changes
Jul 17, 2017
jeddy3
approved these changes
Jul 17, 2017
alexander-akait
approved these changes
Jul 17, 2017
This was referenced Mar 14, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2271
This is the most naive fix I could come up with for the less parametric mixin. It's entirely likely that I've gone in the wrong direction. If so, please give some hints on where to focus. I added tests for the failing cases and ensure they all pass. I did discover another false positive I will open an issue on, but it resisted my early attempts at resolution.
I'll also note that I just merged master and things are a hot mess. linting rules are failing left and right due to new code style but non-updated lint rules. Tests are failing everywhere. I did check that none of the indentation tests are failing.Apparently I didn't do annpm installafter merging master. All clean!