Added: selector-max-universal rule.
#2653
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexander-akait
force-pushed
the
selector-max-universal
branch
from
c7616f4 to
d4c5d58
Compare
hudochenkov
requested changes
Jun 20, 2017
| column: 1, | ||
| }, { | ||
| code: "*, \n* * * {}", | ||
| description: "multiple selectors: greater than max classes", |
There was a problem hiding this comment.
"multiple selectors: greater than max universal selectors"
jeddy3
requested changes
Jun 20, 2017
|
|
||
| ```css | ||
| /* each selector in a selector list is evaluated separately */ | ||
| *.foo *, |
There was a problem hiding this comment.
Please change to:
*.foo,
*.bar * {}That that only three (one more than the max) universal selectors are used.
| ``` | ||
|
|
||
| ```css | ||
| /* `*` is inside `:not()`, so it is evaluated separately */ |
There was a problem hiding this comment.
Please change to:
* > * .foo:not(*) {}
jeddy3
approved these changes
Jun 26, 2017
|
@hudochenkov I've made the changes if you'd like to look them over? |
|
@jeddy3 looks good. Thanks! |
hudochenkov
approved these changes
Jun 26, 2017
jeddy3
force-pushed
the
selector-max-universal
branch
from
f7ccdda to
ebecce3
Compare
jeddy3
force-pushed
the
selector-max-universal
branch
from
ebecce3 to
8aa12c0
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2528
No, it's self explanatory.